fix: features.isDesktopCapturerEnabled error
#166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
changed the title
features.isDesktopCapturerEnabled error
miniak
reviewed
Oct 8, 2023
miniak
approved these changes
Oct 8, 2023
erikian
approved these changes
Oct 8, 2023
codebytere
force-pushed
the
fix-error-desktopcapturer
branch
from
0e841eb
to
fa9f272
Compare
|
🎉 This PR is included in version 2.0.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Oct 14, 2023
taratatach
added a commit
to cozy-labs/cozy-desktop
that referenced
this pull request
Mar 29, 2024
Fixes a crash with Electron v26. See: - electron/remote#154 - electron/remote#166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #154
See #154 (comment):
When
featuresno longer containsisDesktopCapturerEnabled,!features.isDesktopCapturerEnabledevaluates to true, which then means the conditional checks the third condition:features.isDesktopCapturerEnabled()which throws an error: