revert: "Adds TypeScript interface for SafeStorage (#155)" #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2f79ed6.
dsanders11
changed the title
jkleinsc
approved these changes
Aug 30, 2023
|
🎉 This PR is included in version 2.0.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2f79ed6.
Unfortunately CircleCI tests weren't run on #155 (this has been fixed now) so it wasn't noticed that the change broke tests on older Electron versions where
SafeStorageisn't implemented. I explored various ways to try to make this conditional if possible, but there's no clean solution that I'm aware of. Let's revert this so that it doesn't break compatibility with older Electron versions.