Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(make): allow async maker configs #3248

Merged
merged 2 commits into from
Jun 15, 2023
Merged

Conversation

erickzhao
Copy link
Member

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

This PR changes the MakerBase prepareConfig() function to accept asynchronous callbacks.

@erickzhao erickzhao requested a review from a team as a code owner June 9, 2023 21:00
@erickzhao erickzhao changed the title fix(make): allow async maker configs feat(make): allow async maker configs Jun 9, 2023
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

…orge

Co-authored-by: Samuel Attard <sam@electronjs.org>
@erickzhao erickzhao merged commit f0eed93 into main Jun 15, 2023
11 checks passed
@erickzhao erickzhao deleted the fix/accept-async-configs branch June 15, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants