From 7075badd9e7e0c3d5e633e9d8fbb94ae31baa786 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Thu, 7 Mar 2024 14:31:45 +0000 Subject: [PATCH] fix: chrome://process-internals failing to load Co-authored-by: Shelley Vohr --- electron_paks.gni | 2 ++ spec/chromium-spec.ts | 6 ++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/electron_paks.gni b/electron_paks.gni index 25dd04d4072a7..9c59e52b4999f 100644 --- a/electron_paks.gni +++ b/electron_paks.gni @@ -77,6 +77,7 @@ template("electron_extra_paks") { "//content:content_resources", "//content/browser/resources/gpu:resources", "//content/browser/resources/media:resources", + "//content/browser/resources/process:resources", "//content/browser/tracing:resources", "//content/browser/webrtc/resources", "//electron:resources", @@ -96,6 +97,7 @@ template("electron_extra_paks") { # New paks should be added here by default. sources += [ "$root_gen_dir/content/browser/devtools/devtools_resources.pak", + "$root_gen_dir/content/process_resources.pak", "$root_gen_dir/ui/resources/webui_resources.pak", ] deps += [ "//content/browser/devtools:devtools_resources" ] diff --git a/spec/chromium-spec.ts b/spec/chromium-spec.ts index 6d21d1a0c7f0e..d9d2f04380fb6 100644 --- a/spec/chromium-spec.ts +++ b/spec/chromium-spec.ts @@ -2114,7 +2114,8 @@ describe('chromium features', () => { 'chrome://gpu', 'chrome://media-internals', 'chrome://tracing', - 'chrome://webrtc-internals' + 'chrome://webrtc-internals', + 'chrome://process-internals' ]; for (const url of urls) { @@ -2122,8 +2123,9 @@ describe('chromium features', () => { it('loads the page successfully', async () => { const w = new BrowserWindow({ show: false }); await w.loadURL(url); + const host = url.substring('chrome://'.length); const pageExists = await w.webContents.executeJavaScript( - "window.hasOwnProperty('chrome') && window.chrome.hasOwnProperty('send')" + `window.hasOwnProperty('chrome') && window.location.host === '${host}'` ); expect(pageExists).to.be.true(); });