From ebf9784af691e23f176cfdfb15e9b059fea24e6b Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Mon, 21 Aug 2023 00:41:36 +0000 Subject: [PATCH] fix: chrome://gpu failing to load Co-authored-by: Shelley Vohr --- electron_paks.gni | 2 ++ spec/chromium-spec.ts | 26 ++++++++++++++++++++++++-- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/electron_paks.gni b/electron_paks.gni index c3a257ab0f62f..bc6950bee792a 100644 --- a/electron_paks.gni +++ b/electron_paks.gni @@ -61,6 +61,7 @@ template("electron_extra_paks") { "$root_gen_dir/content/browser/tracing/tracing_resources.pak", "$root_gen_dir/content/browser/webrtc/resources/webrtc_internals_resources.pak", "$root_gen_dir/content/content_resources.pak", + "$root_gen_dir/content/gpu_resources.pak", "$root_gen_dir/mojo/public/js/mojo_bindings_resources.pak", "$root_gen_dir/net/net_resources.pak", "$root_gen_dir/third_party/blink/public/resources/blink_resources.pak", @@ -74,6 +75,7 @@ template("electron_extra_paks") { "//chrome/common:resources", "//components/resources", "//content:content_resources", + "//content/browser/resources/gpu:resources", "//content/browser/resources/media:resources", "//content/browser/tracing:resources", "//content/browser/webrtc/resources", diff --git a/spec/chromium-spec.ts b/spec/chromium-spec.ts index 4a0c79bc31958..aa972cc6167f0 100644 --- a/spec/chromium-spec.ts +++ b/spec/chromium-spec.ts @@ -2028,10 +2028,32 @@ describe('chromium features', () => { }); }); + describe('chrome://accessibility', () => { + it('loads the page successfully', async () => { + const w = new BrowserWindow({ show: false }); + await w.loadURL('chrome://accessibility'); + const pageExists = await w.webContents.executeJavaScript( + "window.hasOwnProperty('chrome') && window.chrome.hasOwnProperty('send')" + ); + expect(pageExists).to.be.true(); + }); + }); + + describe('chrome://gpu', () => { + it('loads the page successfully', async () => { + const w = new BrowserWindow({ show: false }); + await w.loadURL('chrome://gpu'); + const pageExists = await w.webContents.executeJavaScript( + "window.hasOwnProperty('chrome') && window.chrome.hasOwnProperty('send')" + ); + expect(pageExists).to.be.true(); + }); + }); + describe('chrome://media-internals', () => { it('loads the page successfully', async () => { const w = new BrowserWindow({ show: false }); - w.loadURL('chrome://media-internals'); + await w.loadURL('chrome://media-internals'); const pageExists = await w.webContents.executeJavaScript( "window.hasOwnProperty('chrome') && window.chrome.hasOwnProperty('send')" ); @@ -2042,7 +2064,7 @@ describe('chromium features', () => { describe('chrome://webrtc-internals', () => { it('loads the page successfully', async () => { const w = new BrowserWindow({ show: false }); - w.loadURL('chrome://webrtc-internals'); + await w.loadURL('chrome://webrtc-internals'); const pageExists = await w.webContents.executeJavaScript( "window.hasOwnProperty('chrome') && window.chrome.hasOwnProperty('send')" );