fix: remove DXDiag telemetry code #41574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VerteDinde
added
semver/patch
clavin
approved these changes
Mar 12, 2024
nornagon
approved these changes
Mar 12, 2024
|
Release Notes Persisted
|
|
I was unable to backport this PR to "28-x-y" cleanly; |
trop
bot
removed
the
target/28-x-y
|
I was unable to backport this PR to "27-x-y" cleanly; |
trop
bot
added
needs-manual-bp/28-x-y
needs-manual-bp/27-x-y
and removed
target/27-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR cherry-picks an upstream change from Chromium: https://chromium-review.googlesource.com/c/chromium/src/+/5337304 This change was causing memory corruption issues and increasing crashes. This fix will land naturally in main and 30-x-y, but we'll cherry-pick it into the other stable release branches to resolve the memory corruption crashes.
Checklist
npm testpassesRelease Notes
Notes: Fixes a memory corruption crash on Windows by removing DXDiag telemetry code.