Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick 2607ddacd643 from chromium #41573

Merged
merged 2 commits into from Mar 12, 2024

Conversation

clavin
Copy link
Member

@clavin clavin commented Mar 12, 2024

Fix primary display race condition crash on Windows

In rare cases, it's possible for the OS to provide us a list of displays
that doesn't contain the primary display. This situation causes
undefined behavior (dereference past vector end) and a crash to occur in
|display::win::(anon)::DisplayInfosToScreenWinDisplays| on builds
without DCHECK enabled.

Bug: 40265302
Change-Id: I2154bedea84478a84147c380610c85d4ea3f703a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5353255
Reviewed-by: David Bienvenu davidbienvenu@chromium.org
Reviewed-by: Robert Liao robliao@chromium.org
Commit-Queue: David Bienvenu davidbienvenu@chromium.org
Cr-Commit-Position: refs/heads/main@{#1271793}

Notes: Backported fix for 40265302.

@clavin clavin requested a review from a team as a code owner March 12, 2024 21:00
@clavin clavin added semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking 29-x-y labels Mar 12, 2024
@VerteDinde
Copy link
Member

CI failures are known flakes

@VerteDinde VerteDinde merged commit 880aee0 into 29-x-y Mar 12, 2024
11 of 13 checks passed
@VerteDinde VerteDinde deleted the cherry-pick/29-x-y/chromium/2607ddacd643 branch March 12, 2024 23:17
Copy link

release-clerk bot commented Mar 12, 2024

Release Notes Persisted

Backported fix for 40265302.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
29-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants