fix: broken shader cache due to compilation error #40467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
trop
bot
added
27-x-y
backport
Refs https://chromium-review.googlesource.com/c/chromium/src/+/4988290 Co-authored-by: deepak1556 <hop2deep@gmail.com>
codebytere
force-pushed
the
trop/27-x-y-bp-fix-broken-shader-cache-due-to-compilation-error-1699322440207
branch
from
af79dbe
to
52cc98a
Compare
codebytere
approved these changes
Nov 7, 2023
VerteDinde
approved these changes
Nov 7, 2023
|
Failing tests are unrelated, merging. |
deepak1556
deleted the
trop/27-x-y-bp-fix-broken-shader-cache-due-to-compilation-error-1699322440207
branch
|
Release Notes Persisted
|
csett86
added a commit
to jitsi/jitsi-meet-electron
that referenced
this pull request
Nov 11, 2023
Contains electron 26 and 27 updates, for details see https://www.electronjs.org/blog/electron-26-0 https://www.electronjs.org/blog/electron-27-0 Contains a fix for Linux that lead to crashes when the graphics drivers changed electron/electron#40467 Mainly this should help with further bugfixes in webrtc as the contained Chromium is implicitly upgraded from 114 to 118. In wayland / pipewire terms we have only minor additions, eg: WaylandWindowDecorations by default: electron/electron#39582 which means we can remove the enable flag we had on this in main.js as its now default.
This was referenced Nov 11, 2023
csett86
added a commit
to jitsi/jitsi-meet-electron
that referenced
this pull request
Nov 11, 2023
Contains electron 26 and 27 updates, for details see https://www.electronjs.org/blog/electron-26-0 https://www.electronjs.org/blog/electron-27-0 Contains a fix for Linux that lead to crashes when the graphics drivers changed electron/electron#40467 Mainly this should help with further bugfixes in webrtc as the contained Chromium is implicitly upgraded from 114 to 118. In wayland / pipewire terms we have only minor additions, eg: WaylandWindowDecorations by default: electron/electron#39582 which means we can remove the enable flag we had on this in main.js as its now default.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #40450
See that PR for details.
Notes: Fix rendering on Linux due to broken shader cache compilation with driver updates