Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: document deprecated systemPreferences APIs #39492

Conversation

dsanders11
Copy link
Member

Backport of #39343.

See that PR for details.

Notes: The systemPreferences.getAppLevelAppearance and systemPreferences.setAppLevelAppearance APIs have been deprecated, as well as the alternate-selected-control-text value for systemPreferences.getColor.

* chore: document deprecated systemPreferences APIs

* chore: forgot systemPreferences.appLevelAppearance

* test: expect deprecation messages
@dsanders11 dsanders11 requested a review from a team as a code owner August 14, 2023 16:17
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 14, 2023
@trop trop bot added 26-x-y backport This is a backport PR semver/minor backwards-compatible functionality labels Aug 14, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 14, 2023
@VerteDinde VerteDinde merged commit ad385bf into electron:26-x-y Aug 14, 2023
12 of 13 checks passed
@release-clerk
Copy link

release-clerk bot commented Aug 14, 2023

Release Notes Persisted

The systemPreferences.getAppLevelAppearance and systemPreferences.setAppLevelAppearance APIs have been deprecated, as well as the alternate-selected-control-text value for systemPreferences.getColor.

@dsanders11 dsanders11 deleted the manual-bp/dsanders11/pr/39343/branch/26-x-y branch August 14, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26-x-y backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants