Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: macOS tray button selection with VoiceOver #39439

Merged
merged 1 commit into from Aug 9, 2023

Conversation

codebytere
Copy link
Member

Backport of #39352.

See that PR for details.

Notes: Fixes an accessibility issue where VoiceOver couldn't trigger the tray action when selected to emit the click event.

@codebytere codebytere added target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch. labels Aug 9, 2023
@codebytere codebytere requested a review from a team August 9, 2023 16:13
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 9, 2023
@trop trop bot added 26-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Aug 9, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 9, 2023
@codebytere codebytere merged commit d2ca670 into 26-x-y Aug 9, 2023
16 checks passed
@codebytere codebytere deleted the fix-voiceover-selection-26 branch August 9, 2023 19:41
@release-clerk
Copy link

release-clerk bot commented Aug 9, 2023

Release Notes Persisted

Fixes an accessibility issue where VoiceOver couldn't trigger the tray action when selected to emit the click event.

@trop
Copy link
Contributor

trop bot commented Aug 9, 2023

I have automatically backported this PR to "24-x-y", please check out #39447

@trop
Copy link
Contributor

trop bot commented Aug 9, 2023

I have automatically backported this PR to "25-x-y", please check out #39448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
26-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes target/24-x-y PR should also be added to the "24-x-y" branch. target/25-x-y PR should also be added to the "25-x-y" branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants