Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: constexpr lookup tables #38800

Merged
merged 1 commit into from Jun 15, 2023

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Jun 15, 2023

Manual backport of #38771. See that PR for details.

Manual intervention needed due to #include shear; no other changes to the patch.

Notes: none

* refactor: use a constexpr lookup table in GetPathConstant()

* refactor: use a constexpr lookup table in SystemPreferences::GetColor()

* refactor: use a constexpr lookup table in SimpleURLLoaderWrapper::Create()
@trop trop bot mentioned this pull request Jun 15, 2023
3 tasks
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 15, 2023
@trop trop bot added 25-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jun 15, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 15, 2023
@ckerr ckerr added target/24-x-y PR should also be added to the "24-x-y" branch. and removed backport This is a backport PR semver/patch backwards-compatible bug fixes 25-x-y labels Jun 15, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 15, 2023
@trop trop bot added 25-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jun 15, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 15, 2023
@codebytere codebytere changed the title refactor: constexpr lookup tables (#38771) refactor: constexpr lookup tables Jun 15, 2023
@ckerr ckerr merged commit f44be42 into 25-x-y Jun 15, 2023
16 checks passed
@ckerr ckerr deleted the refactor/constexpr-lookup-tables--25-x-y branch June 15, 2023 12:27
@release-clerk
Copy link

release-clerk bot commented Jun 15, 2023

No Release Notes

@trop
Copy link
Contributor

trop bot commented Jun 15, 2023

I have automatically backported this PR to "24-x-y", please check out #38807

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
25-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes target/24-x-y PR should also be added to the "24-x-y" branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants