build: revert clang revert #37934
Merged
build: revert clang revert #37934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
added
semver/patch
VerteDinde
approved these changes
Apr 11, 2023
ckerr
approved these changes
Apr 11, 2023
Fixes crash on compiling skia/skia/SkPatchUtils.cpp
jkleinsc
force-pushed
the
revert-clang-revert24
branch
from
5c16ab4
to
dafe142
Compare
zcbenz
approved these changes
Apr 13, 2023
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Checklist
chore: bump chromium to 112.0.5615.10 (24-x-y) #37510 reverted the clang roll in that chromium roll because it crashed compiling third_party/skia/src/utils/SkPatchUtils.cpp on 32-bit Linux ARM. The issue that caused the clang crash has been fixed via MachineCopyPropagation assertion failure llvm/llvm-project#60908. This PR reverts the clang revert and patches in a newer clang for 32-bit Linux ARM.
PR description included and stakeholders cc'd
npm testpassesPR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none