fix: don't set delegate for QLPreviewPanel
#37577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
5 tasks
trop
bot
added
23-x-y
backport
codebytere
approved these changes
Mar 14, 2023
jkleinsc
previously requested changes
Mar 14, 2023
Closed
|
@codebytere @jkleinsc I created #37592 to fix the tests. |
|
@jeremyspiegel it's no problem, i was just going to push directly. |
codebytere
force-pushed
the
trop/23-x-y-bp-fix-don-t-set-delegate-for-qlpreviewpanel--1678801312648
branch
from
010982f
to
d932331
Compare
codebytere
dismissed
jkleinsc’s stale review
Fixed test with old event listener
Co-authored-by: Jeremy Spiegel <jeremy.spiegel@frontapp.com>
codebytere
force-pushed
the
trop/23-x-y-bp-fix-don-t-set-delegate-for-qlpreviewpanel--1678801312648
branch
from
d932331
to
6b51847
Compare
codebytere
deleted the
trop/23-x-y-bp-fix-don-t-set-delegate-for-qlpreviewpanel--1678801312648
branch
|
Release Notes Persisted
|
vikunja-bot
pushed a commit
to go-vikunja/desktop
that referenced
this pull request
Mar 23, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [electron](https://github.com/electron/electron) | devDependencies | minor | [`23.1.4` -> `23.2.0`](https://renovatebot.com/diffs/npm/electron/23.1.4/23.2.0) | --- ### Release Notes <details> <summary>electron/electron</summary> ### [`v23.2.0`](https://github.com/electron/electron/releases/tag/v23.2.0): electron v23.2.0 [Compare Source](electron/electron@v23.1.4...v23.2.0) ### Release Notes for v23.2.0 #### Features - Added the `enableLocalEcho` flag to the session handler `ses.setDisplayMediaRequestHandler()` callback for allowing remote audio input to be echoed in the local output stream when `audio` is a `WebFrameMain`. [#​37529](electron/electron#37529) <span style="font-size:small;">(Also in [24](https://github.com/electron/electron/pull/37528))</span> #### Fixes - Fixed an issue where `BroadcastChannel` did not work correctly when `contextIsolation: false`. [#​37444](electron/electron#37444) <span style="font-size:small;">(Also in [24](https://github.com/electron/electron/pull/37443))</span> - Fixed an issue with potential dock icon duplication on macOS. [#​37624](electron/electron#37624) <span style="font-size:small;">(Also in [22](electron/electron#37623), [24](https://github.com/electron/electron/pull/37625))</span> - Fixed issue with BrowserWindow not updating after call to previewFile. [#​37577](electron/electron#37577) <span style="font-size:small;">(Also in [22](electron/electron#37576), [24](https://github.com/electron/electron/pull/37578))</span> - Improved error messages on `session.cookies.set` failure. [#​37596](electron/electron#37596) <span style="font-size:small;">(Also in [22](electron/electron#37595), [24](https://github.com/electron/electron/pull/37597))</span> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTcuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE1Ny4wIn0=--> Reviewed-on: https://kolaente.dev/vikunja/desktop/pulls/143 Co-authored-by: renovate <renovatebot@kolaente.de> Co-committed-by: renovate <renovatebot@kolaente.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #37530
See that PR for details.
Notes: Fixed issue with BrowserWindow not updating after call to previewFile.