Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add osx-universal flag to usage.txt #1533

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Conversation

erickzhao
Copy link
Member

Summarize your changes:

In #1346, we added support for the --arch=universal flag, but never properly documented CLI usage of the associated OsxUniversalOptions.

For the future, we should also document the @electron/universal options better. We currently have no docs around these flags outside of the source code.

I tested the syntax by running the following command:

DEBUG=electron-universal npx electron-packager . --arch=universal --osx-universal.mergeASARs="true"

From here, I was able to confirm that the Universal package was receiving the options properly:

  electron-universal making a universal app with options {
  mergeASARs: 'true',
  x64AppPath: '/var/folders/wy/zjrnw32x2496ydq6ps7vljfc0000gp/T/electron-packager/electron-packager-universal-sTH01I/electron-quick-start-darwin-x64/electron-quick-start.app',
  arm64AppPath: '/var/folders/wy/zjrnw32x2496ydq6ps7vljfc0000gp/T/electron-packager/electron-packager-universal-sTH01I/electron-quick-start-darwin-arm64/electron-quick-start.app',
  outAppPath: '/var/folders/wy/zjrnw32x2496ydq6ps7vljfc0000gp/T/electron-packager/darwin-universal/electron-quick-start-darwin-universal-ZMutzn/electron-quick-start.app'
}

Sorry, something went wrong.

@erickzhao erickzhao requested a review from a team as a code owner July 17, 2023 21:35
@erickzhao erickzhao mentioned this pull request Jul 17, 2023
3 tasks
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #1533 (94ccb54) into main (72bc2a5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1533   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files          15       15           
  Lines         793      793           
=======================================
  Hits          758      758           
  Misses         35       35           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erickzhao erickzhao changed the title docs: add osx-universal flag to usage.txt fix(docs): add osx-universal flag to usage.txt Jul 17, 2023
@erickzhao erickzhao merged commit 6cdd96b into main Jul 17, 2023
@erickzhao erickzhao deleted the erickzhao-patch-1 branch July 17, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants