fix: remove ElectronAsarIntegrity when asar is disabled #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess fix the tests too 😅 |
MarshallOfSound
force-pushed
the
remove-asar-integrity
branch
from
7169c0e
to
08207a3
Compare
Codecov Report
@@ Coverage Diff @@
## main #1281 +/- ##
=======================================
Coverage 95.61% 95.62%
=======================================
Files 15 15
Lines 776 777 +1
=======================================
+ Hits 742 743 +1
Misses 34 34
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
erickzhao
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
asaris disabled we should remove theElectronAsarIntegrityfield from theInfo.plist