Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require Node 10 #1122

Merged
merged 10 commits into from
Feb 12, 2020
Merged

feat: require Node 10 #1122

merged 10 commits into from
Feb 12, 2020

Conversation

malept
Copy link
Member

@malept malept commented Feb 12, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

After #1121 got merged, we need to require Node 10 in the package and make sure that in the future, dependencies which require higher Node versions fail CI.

BREAKING CHANGE: drop support for Node < 10

Sorry, something went wrong.

@codecov-io
Copy link

codecov-io commented Feb 12, 2020

Codecov Report

Merging #1122 into master will increase coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1122      +/-   ##
=========================================
+ Coverage   99.57%    100%   +0.42%     
=========================================
  Files          14      14              
  Lines         712     712              
=========================================
+ Hits          709     712       +3     
+ Misses          3       0       -3
Impacted Files Coverage Δ
src/mac.js 100% <ø> (ø) ⬆️
src/ignore.js 100% <0%> (+2%) ⬆️
src/unzip.js 100% <0%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ee27c...05a26b3. Read the comment docs.

@malept malept merged commit 55425f9 into master Feb 12, 2020
@malept malept deleted the node-10 branch February 12, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants