New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After upgrading to 24.13.2, Windows NSIS installer Failed to uninstall old application files when there is an app running #8131
Comments
What's your |
thank you so much @mmaietta I have the repo https://github.com/zaichaopan-alianza/electron-builder-24.13.2-nsis-installer you can try. It is from electron-quick-start. My config is very simple. It just {
"name": "electron-quick-start",
"version": "1.0.0",
"description": "A minimal Electron application",
"main": "main.js",
"build": {
"appId": "com.example.electron-quick-start"
},
"scripts": {
"start": "electron .",
"pack": "electron-builder --dir",
"dist": "electron-builder"
},
"repository": "https://github.com/electron/electron-quick-start",
"keywords": [
"Electron",
"quick",
"start",
"tutorial",
"demo"
],
"author": "GitHub",
"license": "CC0-1.0",
"devDependencies": {
"electron": "^29.1.1",
"electron-builder": "24.13.2"
}
} |
Thanks for the repo! Really appreciate it. Will take a look this week when I find some solid time outside of work |
SYSTEMROOT = "c:\windows", The path c:\windows contains special characters, so it needs to be enclosed in double quotes to work properly.
|
@beyondkmp I tried the fix #8133. The issue is no longer reproduced. Thanks a lot! |
Releasing in |
Would this fix be backported to 24.13.3 ? |
Unfortunately, AFAIK it's not possible to backport fixes to previous versions due to the @changesets CI/CD approach. It's only able to roll forward AFAICT. Happy to be disproved otherwise though! |
After upgrading to 24.13.2, when installing nsis installer when app is running, it shows below error "xxxx cannot be closed. Please close it manually and click Retry to continue"
Click Retry will keep showing the dialog again. When click Cancel, it shows "old application files cannot be uninstalled"
Versions before 24.13.2 do not have this issue
When try previous version 24.13.1, It shows dialog xxx is running, click OK to close. After click OK, running app will close and install will continue.
Step to reproduce
Seems like the fix in #8059 introduce this issue. Have anyone run into the same issue?
Thx a million !
The text was updated successfully, but these errors were encountered: