Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve windows update performance #8104

Closed
Usey95 opened this issue Mar 7, 2024 · 3 comments
Closed

Improve windows update performance #8104

Usey95 opened this issue Mar 7, 2024 · 3 comments

Comments

@Usey95
Copy link

Usey95 commented Mar 7, 2024

Now it seems like the way to update windows is to reinstall the whole app by nsis which behaves differently in win7/10/11.
Sometimes it's slow, sometimes it will alert permission dialog by system. It's not "quiet" at all.

The update experience in Mac is good, how can I achieve that in windows? Or is there any other way to "hot update"?

Thank you.

@mmaietta
Copy link
Collaborator

mmaietta commented Mar 8, 2024

I'm not sure I follow. Is the differential update not working? The only thing that was changed recently was the signature validation in #8051

On mac, it's an entirely different process as the zip has to be served over localhost to the native electron updater

@Usey95
Copy link
Author

Usey95 commented Mar 10, 2024

I'm not sure I follow. Is the differential update not working? The only thing that was changed recently was the signature validation in #8051

On mac, it's an entirely different process as the zip has to be served over localhost to the native electron updater

2024-03-10 18:01:37.768 [info] File has 5214 changed blocks 2024-03-10 18:01:37.785 [info] Full: 145,907.81 KB, To download: 105,893.78 KB (73%) 2024-03-10 18:02:00.795 [info] New version 1.0.0-alpha.7680 has been downloaded to C:\Users\hi\AppData\Local\updater\pending\Setup 1.0.0-alpha.7680.exe

I guess differential update is working as the log prints.

I set autoInstallOnAppQuit = true. When user quits the app, a promt will show to allow changes to make by the app. And then the desktop will flash twice to complete slient install. It takes about 10s to do that and in this duration the shortcut is unable to use.

So, this update progress is not silent. We don't want our user to notice our update since we update quite frequently. Is there anything I'm missing or is it because of the alpha version or buildnumber difference? Or everyone else just use there own script to patch app.asar or something. I didn't see much complains about it.

@Usey95
Copy link
Author

Usey95 commented Mar 18, 2024

After a deeper dug, we gave up NSIS silent auto update.

It is not possible not showing prompts since it will modify file inside Program Files.

@Usey95 Usey95 closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants