Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressor "lzo" is not supported! #7013

Closed
MikeJerred opened this issue Jul 20, 2022 · 9 comments
Closed

Compressor "lzo" is not supported! #7013

MikeJerred opened this issue Jul 20, 2022 · 9 comments

Comments

@MikeJerred
Copy link
Contributor

  • Electron-Builder Version: 23.2.0
  • Node Version: 16.14.2
  • Electron Version: 19.0.4
  • Electron Type (current, beta, nightly): current
  • Target: linux snap x64

If I add this setting to electron-builder.yml:

snap:
  compression: lzo

Then the build fails with:

  ⨯ cannot execute  cause=exit status 1
                    errorOut=/home/runner/.cache/electron-builder/appimage/appimage-12.0.1/linux-x64/mksquashfs: Compressor "lzo" is not supported!
    /home/runner/.cache/electron-builder/appimage/appimage-12.0.1/linux-x64/mksquashfs: Compressors available:
    	gzip (default)
    	xz

Either this is a bug, or the documentation is incorrect at https://www.electron.build/configuration/snap.html which states:

compression “xz” | “lzo” | “undefined” - Sets the compression type for the snap. Can be xz, lzo, or null.
@mkinitcpio
Copy link

Same problem.

@mkinitcpio
Copy link

Update:
I found the root of problem. This version mksquashfs that used for build package don't have lzo compression flag.

Screenshot Screen Shot 2022-09-04 at 2 31 34 AM

Quick fix: create a symlink to the original mksquashfs from OS (MAC/linux)

For me it works now!

@MikeJerred
Copy link
Contributor Author

@mkinitcpio do your AppImage builds still work?

@mkinitcpio
Copy link

@MikeJerred Not tested yet, but now I have a problem with publishing to the snap store. Problem with checksum :(

@MikeJerred
Copy link
Contributor Author

@mkinitcpio Might be related to this PR: #7110

I managed to get compression working but it required some monkey-patching of app-builder-lib

@mkinitcpio
Copy link

mkinitcpio commented Sep 4, 2022

@MikeJerred, Yeees, I used you hack.
So, I finded a solution how to publish my package.

https://forum.snapcraft.io/t/snapcraft-review-fails-wrong-permissions-electron-builder/10061

And steps to build "normal" package:

  1. Use your patch for app-builder-lib
  2. Use the solution from the link that I send before.
  3. Upload.

I have no possibility to check it for AppImage (I use only snap in my app).

Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added Stale and removed Stale labels Jan 29, 2024
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Apr 29, 2024
Copy link
Contributor

This issue was closed because it has been stalled for 30 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants