Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
25
contributors
Commits on Oct 2, 2024
Commits on Oct 6, 2024
-
fix: Path does not end with the package name (#8560)
fix #8558 The @isaacs/cliui package depends on string-width-cjs@4.2.3, but the package that's actually downloaded is string-width@4.2.3. The name in the path doesn't match the original name, which is causing an error. Fix solution: Truncate based on scope depth, not by name. ``` "string-width-cjs": { "from": "string-width", "version": "4.2.3", "resolved": "https://registry.npmjs.org/string-width/-/string-width-4.2.3.tgz", "description": "Get the visual width of a string - the number of columns required to display it", "license": "MIT", "author": { "name": "Sindre Sorhus", "email": "sindresorhus@gmail.com", "url": "sindresorhus.com" }, "homepage": "https://github.com/sindresorhus/string-width#readme", "repository": "git+https://github.com/sindresorhus/string-width.git", "path": "/Users/beyondkmp/Code/deepFocus/node_modules/.pnpm/string-width@4.2.3/node_modules/string-width", } ``` --------- Co-authored-by: beyondkmp <beyondkmkp@gmail.com>
-
-
-
Commits on Oct 7, 2024
-
fix: support including node_modules in other subdirectories (#8562)
fix #6080 and support including node_modules in other subdirectories **How to fix** 1. No file patterns - The final File patterns are `["**/*", "!**/node_modules/**", "!dist{,/**/*}", ...] ` 2. File patterns with other sub node_modules `["/*", "**/sub/node_modules/**"]` - File patterns are `["**/*", "!**/node_modules/**", "**/sub/node_modules/**", "!dist{,/**/*}", ...]` 3. File patterns without sub node_modules - The final File patterns are `["**/*", "!**/node_modules/**", "!dist{,/**/*}", ...]` The final patterns above all filter out the node_modules in the app root directory. In filter.ts, we handle this by returning false by default if relative === 'node_modules', so it won't be filtered out. https://github.com/electron-userland/electron-builder/blob/e2c79819751454dbd1a939610d66e940b5dfb73d/packages/app-builder-lib/src/util/filter.ts#L60-L62 However, if you really want to filter out the node_modules in the app directory, you can use `["!node_modules/**/*"]` to filter it. **Two points to note** 1. Now `["**/*", "**/sub/node_modules"]` cannot match. Only `["**/*", "**/sub/node_modules/**"]` will match. For a relative path of` sub/node_modules`, if don't add a `/ ` at the end, we can only use `**/sub/node_module` to match. If add a `/` at the end, we can only use `**/sub/node_module/**` to match. **I currently prefer that `**/sub/node_modules/**` matches, as this aligns more with conventional usage.** 2. `*/sub/node_modules/**` cannot match because the relative path is `sub/node_modules`, and there's no extra directory at the beginning. --------- Co-authored-by: beyondkmp <beyondkmkp@gmail.com>
Commits on Oct 9, 2024
-
-
-
feat: allowing additional entries in .desktop file, such as `[Desktop…
… Actions <actionName>]` (#8572)
-
fix: add additional default exclusions (
node_gyp_bins, `pnpm-lock.y……aml`, `.obj`) to copy logic (#8577)
Commits on Oct 10, 2024
-
-
fix: packages in the workspace not being under node_modules (#8576)
fix develar/app-builder#141 reproduced error info ``` ● yarn several workspaces /tmp/et-db411cd21f3bbd882f3a5a30c58db6ff/t-kIKFAh/test-project-2/packages/foo/package.json must be under /tmp/et-db411cd21f3bbd882f3a5a30c58db6ff/t-kIKFAh/test-project-2/packages/test-app/ 30 | const index = file.indexOf(NODE_MODULES_PATTERN) 31 | if (index < 0) { > 32 | throw new Error(`${file} must be under ${srcWithEndSlash}`) | ^ 33 | } else { 34 | return file.substring(index + 1 /* leading slash */) 35 | } at getRelativePath (../packages/app-builder-lib/src/util/filter.ts:32:13) at AsarPackager.unpackPattern (../packages/app-builder-lib/src/util/filter.ts:57:20) at AsarPackager.createPackageFromFiles (../packages/app-builder-lib/src/asar/asarUtil.ts:129:82) at AsarPackager.pack (../packages/app-builder-lib/src/asar/asarUtil.ts:49:41) at ../packages/app-builder-lib/src/platformPackager.ts:439:11 at async Promise.all (index 0) at AsyncTaskManager.awaitTasks (../packages/builder-util/src/asyncTaskManager.ts:65:25) at LinuxPackager.doPack (../packages/app-builder-lib/src/platformPackager.ts:293:5) at LinuxPackager.pack (../packages/app-builder-lib/src/platformPackager.ts:138:5) at Packager.doBuild (../packages/app-builder-lib/src/packager.ts:459:9) at executeFinally (../packages/builder-util/src/promise.ts:12:14) at Packager.build (../packages/app-builder-lib/src/packager.ts:393:31) at packAndCheck (src/helpers/packTester.ts:188:41) at src/helpers/packTester.ts:132:36 at executeFinally (../packages/builder-util/src/promise.ts:12:14) ``` Currently, the returned node_modules paths are no longer symlinks, but resolved paths. For example, packages in pnpm workspace/yarn workspace are not under node_modules. All previous getRealSource/getRelativePath methods were based on node_modules in the path, which was relatively tricky. https://github.com/electron-userland/electron-builder/blob/a25d04d5a8e58b447f0462673a4362414da9ed27/packages/app-builder-lib/src/util/appFileCopier.ts#L191-L203 https://github.com/electron-userland/electron-builder/blob/a25d04d5a8e58b447f0462673a4362414da9ed27/packages/app-builder-lib/src/util/filter.ts#L28-L36 Solution: Directly include relativeNodeModulesPath in the file stats. This is simple and easy to understand. --------- Co-authored-by: Mike Maietta <mmaietta@users.noreply.github.com>
-
Commits on Oct 11, 2024
Commits on Oct 12, 2024
Commits on Oct 13, 2024
Commits on Oct 14, 2024
-
chore(deps): update fast-xml-parser to 4.4.1 (#8593)
chore(deps): update fast-xml-parser to 4.4.1 to fix https://github.com/electron-userland/electron-builder/security/dependabot/31
-
chore(deps): update jest to 29.7.0 (#8594)
chore(deps): update jest to 29.7.0 to fix https://github.com/electron-userland/electron-builder/security/dependabot/26
Commits on Oct 15, 2024
Commits on Oct 16, 2024
-
chore: refactor Publishers out of app-builder-lib into electron-publi…
…sh and add to docs site (#8596)
-
fix: add quotes to surround file path during azure signing to handle …
…files with spaces (#8606)
-
Commits on Oct 23, 2024
Commits on Oct 25, 2024
Commits on Oct 26, 2024
Commits on Oct 28, 2024
-
fix: remove concurrency of windows codesign to resolve azure trusted …
…signing file locks(#8632)
There are no files selected for viewing
This file was deleted.