Migration to buildkite

[leo-ri]

No description provided.

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-07-07T16:27:06.503+0000

• Duration: 4 min 19 sec

Test stats 🧪

Test	Results
Failed	0
Passed	397
Skipped	40
Total	437

[elasticmachine]

📚 Go benchmark report

Diff with the main branch

goos: linux
goarch: amd64
pkg: github.com/elastic/go-libaudit/v2/aucoalesce
cpu: Intel(R) Xeon(R) CPU @ 2.30GHz
                   │ build/main/bench.out │             bench.out              │
                   │        sec/op        │    sec/op     vs base              │
CoalesceMessages-8           5.979µ ± ∞ ¹   5.897µ ± ∞ ¹  -1.37% (p=0.016 n=5)
¹ need >= 6 samples for confidence interval at level 0.95

                   │ build/main/bench.out │           bench.out            │
                   │         B/op         │     B/op       vs base         │
¹ need >= 6 samples for confidence interval at level 0.95

                   │ build/main/bench.out │           bench.out            │
                   │      allocs/op       │  allocs/op   vs base           │
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal

pkg: github.com/elastic/go-libaudit/v2/auparse
                                     │ build/main/bench.out │             bench.out              │
                                     │        sec/op        │    sec/op     vs base              │
ExtractKeyValuePairs/short_message-8           2.478µ ± ∞ ¹   2.538µ ± ∞ ¹  +2.42% (p=0.032 n=5)
ParseAuditHeaderRegex-8                        869.7n ± ∞ ¹   897.1n ± ∞ ¹  +3.15% (p=0.008 n=5)
ParseLogLine-8                                 338.3n ± ∞ ¹   351.3n ± ∞ ¹  +3.84% (p=0.008 n=5)
geomean                                        2.788µ         2.894µ        +3.77%
¹ need >= 6 samples for confidence interval at level 0.95

                                     │ build/main/bench.out │               bench.out               │
                                     │         B/op         │     B/op       vs base                │
geomean                                                   ³                  +0.09%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

                                     │ build/main/bench.out │              bench.out              │
                                     │      allocs/op       │  allocs/op   vs base                │
geomean                                                   ³                +0.00%               ³
¹ need >= 6 samples for confidence interval at level 0.95
² all samples are equal
³ summaries must be >0 to compute geomean

report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat

[jlind23]

@cachedout while migrating this repo we discovered that benchmarks results are pushed to a central bucket. Are you using this results for any kind of automation?

[mrodm]

Could this script launch .ci/test.sh, it looks like this script is doing more or less the same as that other file.

Or maybe, could we use that script directly as a command in the step definition ?

[mrodm]

Where is it needed root ? In .ci/test.sh, it looks like it is not needed root.

[leo-ri]

These tests are indeed running by non-root user in Jenkins, and the current builkite agent has user root inside the container, as a result, the different groups of tests will be running in these two cases. For making it the same, I changed a little bit the script (partially related to all comments)

[mrodm]

Maybe we can keep the same shellscript under .ci to be used in .buildkite.
In this case, here it could be directly used that file:

Suggested change

	- ".buildkite/scripts/bench.sh"
	- ".ci/bench.sh"

WDYT ? @leo-ri @alexsapran

[mrodm]

Checking Jenkins pipeline, in that pipeline it is added comments in PRs for every pull request:

go-libaudit/.ci/Jenkinsfile

Line 68 in 3a9164f

notifyBuildResult(prComment: true, goBenchmarkComment: true)

Should we add it now also in Buildkite ?
This is an example from elastic-package
https://github.com/elastic/elastic-package/blob/604c606c86bea611975fa9c9722a30a44b2204fb/catalog-info.yaml#L56-L57

[jlind23]

@mrodm @alexsapran don't you think we can remove the Jenkinsfile at the same time here?

[jlind23]

@leo-ri don't you think the .ci folder can be completely removed?

[leo-ri]

@leo-ri don't you think the .ci folder can be completely removed?

discussed in person