Support $ and / in ccr follow #99892
Merged
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the renameReplacement variable in the restore snapshot request is intended to be a string literal. However, when a string is passed to replaceAll in java $ and / will be treated as special characters. This means that restoring indices with $ in them occasionally breaks. This commit fixes the issue by quoting the special characters before calling replaceAll. Fixes elastic#99078.
Tim-Brooks
added
>bug
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Hi @Tim-Brooks, I've created a changelog YAML for you. |
...ck/plugin/ccr/src/internalClusterTest/java/org/elasticsearch/xpack/ccr/IndexFollowingIT.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/snapshots/RestoreService.java
Outdated
Show resolved
Hide resolved
Tim-Brooks
changed the title
idegtiarenko
approved these changes
Oct 4, 2023
|
I believe the failed test has already been muted in #100192 |
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Oct 4, 2023
Currently the renameReplacement variable in the restore snapshot request is intended to be a string literal for ccr. However, when a string is passed to replaceAll in java $ and / will be treated as special characters. This means that following indices with $ in them breaks. This commit fixes the issue by quoting the special characters before calling replaceAll. Fixes elastic#99078.
This was referenced Oct 4, 2023
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Oct 4, 2023
Currently the renameReplacement variable in the restore snapshot request is intended to be a string literal for ccr. However, when a string is passed to replaceAll in java $ and / will be treated as special characters. This means that following indices with $ in them breaks. This commit fixes the issue by quoting the special characters before calling replaceAll. Fixes elastic#99078.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 4, 2023
Currently the renameReplacement variable in the restore snapshot request is intended to be a string literal for ccr. However, when a string is passed to replaceAll in java $ and / will be treated as special characters. This means that following indices with $ in them breaks. This commit fixes the issue by quoting the special characters before calling replaceAll. Fixes #99078.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 4, 2023
Currently the renameReplacement variable in the restore snapshot request is intended to be a string literal for ccr. However, when a string is passed to replaceAll in java $ and / will be treated as special characters. This means that following indices with $ in them breaks. This commit fixes the issue by quoting the special characters before calling replaceAll. Fixes #99078.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the renameReplacement variable in the restore snapshot request
is intended to be a string literal for ccr. However, when a string is passed
to replaceAll in java $ and / will be treated as special characters. This
means that following indices with $ in them breaks. This commit fixes the
issue by quoting the special characters before calling replaceAll.
Fixes #99078.