Adjust the test based on the year change #118827
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astefan
added
>test
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
carlosdelest
approved these changes
Dec 17, 2024
alex-spies
approved these changes
Dec 17, 2024
|
Ah, main+8.x are taken care of in #118815 |
This was referenced Dec 17, 2024
astefan
added a commit
to astefan/elasticsearch
that referenced
this pull request
Dec 17, 2024
bpintea
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
This works.. for a while :)
I guess it can stay, but at some point it might be worth limiting the impact of TODAY()'s variation. (SELECT first_name, hire_date FROM employees WHERE hire_date > DATE_TRUNC('CENTURY', TODAY()) - INTERVAL 11 YEARS ORDER BY first_name ASC LIMIT 5)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 17, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 17, 2024
sarog
pushed a commit
to sarog/elasticsearch
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118810