Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update alias.asciidoc - remove_index #118553

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Update alias.asciidoc - remove_index #118553

merged 3 commits into from
Dec 17, 2024
+21 −0

Conversation

mimol91
Copy link
Contributor

@mimol91 mimol91 commented Dec 12, 2024 •
edited
Loading

Update Alias Doc to add remove_index

@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Dec 12, 2024 •
edited
Loading

💚 CLA has been signed

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.16.3 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Dec 12, 2024
@benwtrent benwtrent added >docs General docs changes :Search Foundations/Search Catch all for Search Foundations and removed needs:triage Requires assignment of a team area label labels Dec 12, 2024
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch labels Dec 12, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

john-wagster
john-wagster approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@john-wagster john-wagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-wagster john-wagster self-assigned this Dec 13, 2024
@john-wagster
Copy link
Contributor

@elasticmachine test this please

@john-wagster john-wagster added the auto-backport Automatically create backport pull requests when merged label Dec 13, 2024
@john-wagster john-wagster changed the base branch from 8.16 to main December 13, 2024 18:30
@john-wagster john-wagster requested review from a team as code owners December 13, 2024 18:30
@john-wagster john-wagster changed the base branch from main to 8.16 December 13, 2024 18:31
@john-wagster
Copy link
Contributor

There's a few things we'll need to do on this one @mimol91. First can you rebase this on main and update the PR. And then also because of how the documentation testing works we either need to break this change out (so that in the test it's not deleting the index) or probably the easiest thing to do is to move the new section to the bottom of that page of the documentation so that the last thing to happen is the index gets deleted. I believe that will make the CI happy (at least worth a shot).

@mimol91 mimol91 changed the base branch from 8.16 to main December 15, 2024 13:37
@john-wagster
Copy link
Contributor

@elasticmachine test this please

@mimol91
Copy link
Contributor Author

mimol91 commented Dec 16, 2024

I cannot see CI result.
Is there anything that I can do?

@john-wagster
Copy link
Contributor

@elasticmachine test this please

@john-wagster
Copy link
Contributor

Let me rerun CI and take a look myself and see if I can help; I'll try to do that today if I can find some time

@john-wagster
Copy link
Contributor

ok was able to determine the problem. The index in your docs update is a protected index name. We just need to change all references in your addition to a different index name something like index_to_remove instead of logs-nginx.access-prod (there's two references I believe) and it should pass the CI. I'm happy to do that and validate it works if you want to give me write access to your branch on your fork or feel free to do that and I'll kick off CI as soon as I see you make the change! Thanks for being patient with me here.

@mimol91
Update alias.asciidoc
Loading
Loading status checks…
cb985aa 
Add section about removing index
@mimol91
Copy link
Contributor Author

mimol91 commented Dec 17, 2024

Thanks for guiding me
Fingers crossed this will work

@john-wagster
Copy link
Contributor

@elasticmachine test this please

@john-wagster
Merge branch 'main' into patch-2
Loading
Loading status checks…
7877494
@john-wagster
Copy link
Contributor

@elasticmachine test this please

@john-wagster
Copy link
Contributor

@elasticmachine update branch

@elasticmachine
Merge branch 'main' into patch-2
Loading
Loading status checks…
a7f24e5
@john-wagster
Copy link
Contributor

@elasticmachine test this please

@john-wagster john-wagster merged commit f64c05a into elastic:main Dec 17, 2024
6 checks passed
This was referenced Dec 17, 2024
Merged
Merged
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.17
✅ 8.x
✅ 7.17

john-wagster pushed a commit to john-wagster/elasticsearch that referenced this pull request Dec 17, 2024
@mimol91 @john-wagster
Update alias.asciidoc (elastic#118553)
Loading
Loading status checks…
0015e78 
Add section about removing index
john-wagster pushed a commit to john-wagster/elasticsearch that referenced this pull request Dec 17, 2024
@mimol91 @john-wagster
Update alias.asciidoc (elastic#118553)
Loading
Loading status checks…
6d8501b 
Add section about removing index
elasticsearchmachine pushed a commit that referenced this pull request Dec 17, 2024
@john-wagster @mimol91
Update alias.asciidoc (#118553) (#118861)
03897a9 
Add section about removing index

Co-authored-by: Adam Szaraniec <szaraniec.adam@gmail.com>
elasticsearchmachine pushed a commit that referenced this pull request Dec 17, 2024
@john-wagster @mimol91
Update alias.asciidoc (#118553) (#118859)
Loading
Loading status checks…
dbe3b6d 
Add section about removing index

Co-authored-by: Adam Szaraniec <szaraniec.adam@gmail.com>
elasticsearchmachine pushed a commit that referenced this pull request Dec 17, 2024
@john-wagster @mimol91
Update alias.asciidoc (#118553) (#118860)
Loading
Loading status checks…
49b18e2 
Add section about removing index

Co-authored-by: Adam Szaraniec <szaraniec.adam@gmail.com>
navarone-feekery pushed a commit to navarone-feekery/elasticsearch that referenced this pull request Dec 26, 2024
@mimol91 @navarone-feekery
Update alias.asciidoc (elastic#118553)
3189ca3 
Add section about removing index
sarog pushed a commit to sarog/elasticsearch that referenced this pull request Jan 22, 2025
@john-wagster @mimol91 @sarog
Update alias.asciidoc (elastic#118553) (elastic#118859)
b7fd4c9 
Add section about removing index

Co-authored-by: Adam Szaraniec <szaraniec.adam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-wagster john-wagster

Assignees

@john-wagster john-wagster

Labels
auto-backport Automatically create backport pull requests when merged >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team :Search Foundations/Search Catch all for Search Foundations Team:Docs Meta label for docs team Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v7.17.27 v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mimol91 @elasticsearchmachine @john-wagster @benwtrent @elasticmachine