Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] Reset max page size to settings value (#109449) #109532

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

prwhelan
Copy link
Member

When a circuit breaker exception causes the transform checkpoint to fail, the transform will reduce the max page size to the value specified by the circuit breaker. Transform will retry the checkpoint until the search succeeds.

When the search succeeds, the Transform will now reset the max search size to the value specified in the Transform settings rather than the now-deprecated value in the Latest/Pivot config.

Fix #109308

When a circuit breaker exception causes the transform checkpoint to
fail, the transform will reduce the max page size to the value specified
by the circuit breaker.  Transform will retry the checkpoint until the
search succeeds.

When the search succeeds, the Transform will now reset the max search
size to the value specified in the Transform settings rather than the
now-deprecated value in the Latest/Pivot config.

Fix elastic#109308
@prwhelan prwhelan added :ml/Transform Transform Team:ML Meta label for the ML team labels Jun 10, 2024
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.14.1 labels Jun 10, 2024
@prwhelan prwhelan added >bug and removed needs:triage Requires assignment of a team area label labels Jun 10, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine
Copy link
Collaborator

Hi @prwhelan, I've created a changelog YAML for you.

Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please double check whether the backport PR should have 2 docs/changelog files or just one

@prwhelan
Copy link
Member Author

@elasticmachine run elasticsearch-ci/rest-compatibility

@prwhelan prwhelan merged commit 68b3ee8 into elastic:8.14 Jun 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :ml/Transform Transform Team:ML Meta label for the ML team v8.14.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants