Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency check for ignored licenses #104736

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented Jan 25, 2024

if there are no dependencies declared and the license file is marked as ignored, no exception
should be thrown and dependencylicense check should pass.

Fixes issues we identified in #104628

if there are no dependencies declared and the license file is marked as ignored, no exception
should be thrown and dependencylicense check should pass.
@breskeby breskeby requested a review from a team as a code owner January 25, 2024 09:49
@breskeby breskeby added >non-issue :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v8.12.1 v8.13.0 v7.17.18 labels Jan 25, 2024
@breskeby breskeby self-assigned this Jan 25, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby breskeby added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport-and-merge labels Jan 25, 2024
@elasticsearchmachine elasticsearchmachine merged commit 82c4cc7 into elastic:main Jan 25, 2024
@breskeby breskeby deleted the handle-ignored-licenses branch January 25, 2024 10:45
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Jan 25, 2024
if there are no dependencies declared and the license file is marked as
ignored, no exception should be thrown and dependencylicense check
should pass.

Fixes issues we identified in elastic#104628
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Jan 25, 2024
if there are no dependencies declared and the license file is marked as
ignored, no exception should be thrown and dependencylicense check
should pass.

Fixes issues we identified in elastic#104628
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.12
7.17

rockdaboot added a commit to rockdaboot/elasticsearch that referenced this pull request Jan 25, 2024
elasticsearchmachine pushed a commit that referenced this pull request Jan 25, 2024
if there are no dependencies declared and the license file is marked as
ignored, no exception should be thrown and dependencylicense check
should pass.

Fixes issues we identified in #104628
henningandersen pushed a commit to henningandersen/elasticsearch that referenced this pull request Jan 25, 2024
if there are no dependencies declared and the license file is marked as
ignored, no exception should be thrown and dependencylicense check
should pass.

Fixes issues we identified in elastic#104628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v7.17.18 v8.12.1 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants