Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Antarctica/Vostok timezone differences #104610

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Jan 22, 2024

2023d has changed Antartica/Vostok, this means the JDK and joda timezones are out of sync.

This fixes #104544

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@thecoop thecoop added >test Issues or PRs that are addressing/adding tests :Core/Infra/Core Core issues without another label v7.17.18 labels Jan 22, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Jan 22, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@rjernst
Copy link
Member

rjernst commented Jan 22, 2024

Rather than ignoring it, should we be updating Joda? 2.12.6 appears to contain the relevant timezone update:
https://www.joda.org/joda-time/changes-report.html#a2.12.6

@thecoop
Copy link
Member Author

thecoop commented Jan 24, 2024

Lets try that - #104720

@thecoop
Copy link
Member Author

thecoop commented Jan 24, 2024

Upgrading joda doesn't fix this test - there's still some jdks where the timezone data differs.

@thecoop thecoop requested a review from rjernst January 24, 2024 17:04
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@thecoop thecoop merged commit 76be62a into elastic:7.17 Jan 25, 2024
@thecoop thecoop deleted the timezone-vostok branch January 25, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v7.17.18
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants