Ensure there's only one newline added with new version declarations #104519
+82
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecoop
added
>non-issue
:Core/Infra/Core
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
approved these changes
Jan 18, 2024
|
Yeah, spotless doesn't care if there's one or two lines between class members. |
rjernst
approved these changes
Jan 23, 2024
|
Yeah, this is really hacky, but it's the only way I could find to do it, and the initialization is covered by tests |
thecoop
added
the
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
thecoop
added a commit
to thecoop/elasticsearch
that referenced
this pull request
Jan 24, 2024
thecoop
added a commit
to thecoop/elasticsearch
that referenced
this pull request
Jan 24, 2024
thecoop
added a commit
that referenced
this pull request
Jan 24, 2024
thecoop
added a commit
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaParser by default adds two newlines to new member declarations, when lexical preserving printing is used. This is defined in the ConcreteSyntaxModel default formatting, within a (private) static map for each declaration type.
This replaces the default CSM format for class declarations with our own, that is virtually identical apart from having only one newline after each member declaration, rather than two. This ensures that JavaParser maintains our existing formatting style when adding new version members to Version.java