-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention IndexFormatToo{Old,New}Exception
as corruption
#104204
Mention IndexFormatToo{Old,New}Exception
as corruption
#104204
Conversation
If a file header is corrupted then the exception may be reported as a bad index format version rather than a checksum mismatch. This commit adjusts the docs to cover this case.
Documentation preview: |
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-distributed (Team:Distributed) |
@@ -50,8 +57,7 @@ system previously confirmed to {es} that this file was durably synced to disk. | |||
On Linux this means that the `fsync()` system call returned successfully. {es} | |||
sometimes reports that an index is corrupt because a file needed for recovery | |||
is missing, or it exists but has been truncated or is missing its footer. This | |||
indicates that your storage system acknowledges durable writes incorrectly or | |||
that some external process has modified the data {es} previously wrote to disk. | |||
may indicate that your storage system acknowledges durable writes incorrectly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think this change is related to the title. Was it intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it was intentional, I meant to fix this in the last change to this file but missed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you like to remove the mention of another process? My understanding is that it is still a possibility. Is it mentioned anywhere else?
…104207) If a file header is corrupted then the exception may be reported as a bad index format version rather than a checksum mismatch. This commit adjusts the docs to cover this case.
…104208) If a file header is corrupted then the exception may be reported as a bad index format version rather than a checksum mismatch. This commit adjusts the docs to cover this case.
If a file header is corrupted then the exception may be reported as a
bad index format version rather than a checksum mismatch. This commit
adjusts the docs to cover this case.