Avoid throw AssertionError in ThrowingDriverContext #103888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
:Analytics/ES|QL
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
alex-spies
approved these changes
Jan 4, 2024
| public class ThrowingDriverContext extends DriverContext { | ||
| public ThrowingDriverContext() { | ||
| /** | ||
| * A driver context that doesn't support any interaction. Consider it as a place holder where we need a dummy driver context. |
There was a problem hiding this comment.
++ for the nice javadoc, thanks!
|
@alex-spies @ChrisHegarty Thanks for review. |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jan 4, 2024
ThrowingDriverContext can bring down Elasticsearch instances as it throws AssertionError. An unreleased bug caused this class to throw AssertionError. This change replaces AssertionError with an assertion and an unsupported exception. I attempted to remove this class, but it requires additional effort to make ExpressionEvaluator.Factory Describable.
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Jan 4, 2024
ThrowingDriverContext can bring down Elasticsearch instances as it throws AssertionError. An unreleased bug caused this class to throw AssertionError. This change replaces AssertionError with an assertion and an unsupported exception. I attempted to remove this class, but it requires additional effort to make ExpressionEvaluator.Factory Describable.
dnhatn
removed
backport pending
auto-backport-and-merge
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 4, 2024
ThrowingDriverContext can bring down Elasticsearch instances as it throws AssertionError. An unreleased bug caused this class to throw AssertionError. This change replaces AssertionError with an assertion and an unsupported exception. I attempted to remove this class, but it requires additional effort to make ExpressionEvaluator.Factory Describable.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 4, 2024
ThrowingDriverContext can bring down Elasticsearch instances as it throws AssertionError. An unreleased bug caused this class to throw AssertionError. This change replaces AssertionError with an assertion and an unsupported exception. I attempted to remove this class, but it requires additional effort to make ExpressionEvaluator.Factory Describable.
jbaiera
pushed a commit
to jbaiera/elasticsearch
that referenced
this pull request
Jan 10, 2024
ThrowingDriverContext can bring down Elasticsearch instances as it throws AssertionError. An unreleased bug caused this class to throw AssertionError. This change replaces AssertionError with an assertion and an unsupported exception. I attempted to remove this class, but it requires additional effort to make ExpressionEvaluator.Factory Describable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ThrowingDriverContext can bring down Elasticsearch instances as it throws AssertionError. An unreleased bug caused this class to throw AssertionError. This change replaces AssertionError with an assertion and an unsupported exception. I attempted to remove this class, but it requires additional effort to make ExpressionEvaluator.Factory Describable.