New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IronBank BASE_IMAGE with ironbank prefix #102720
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supports local testing. It should not be included in hardening_manifest.yml, which injects the scope at runtime.
jbudz
added
:Delivery/Build
Build or test infrastructure
:Delivery/Packaging
RPM and deb packaging, tar and zip archives, shell and batch scripts
labels
Nov 28, 2023
elasticsearchmachine
added
Team:Delivery
Meta label for Delivery team
v8.12.0
external-contributor
Pull request authored by a developer outside the Elasticsearch team
labels
Nov 28, 2023
Pinging @elastic/es-delivery (Team:Delivery) |
jbudz
added
external-contributor
Pull request authored by a developer outside the Elasticsearch team
v8.12.0
and removed
external-contributor
Pull request authored by a developer outside the Elasticsearch team
v8.12.0
labels
Nov 28, 2023
mark-vieira
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @jbudz. LGTM.
mark-vieira
added
auto-backport-and-merge
Automatically create backport pull requests and merge when ready
v8.11.2
v7.17.16
labels
Nov 30, 2023
mark-vieira
pushed a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Nov 30, 2023
This supports local testing. It should not be included in hardening_manifest.yml, which injects the scope at runtime.
mark-vieira
pushed a commit
to mark-vieira/elasticsearch
that referenced
this pull request
Nov 30, 2023
This supports local testing. It should not be included in hardening_manifest.yml, which injects the scope at runtime. # Conflicts: # distribution/docker/src/docker/Dockerfile
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 30, 2023
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport-and-merge
Automatically create backport pull requests and merge when ready
:Delivery/Build
Build or test infrastructure
:Delivery/Packaging
RPM and deb packaging, tar and zip archives, shell and batch scripts
external-contributor
Pull request authored by a developer outside the Elasticsearch team
>non-issue
Team:Delivery
Meta label for Delivery team
v7.17.16
v8.11.2
v8.12.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports local testing. It should not be included in hardening_manifest.yml, which injects the scope at runtime.
Prompted by https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch/-/merge_requests/140#note_1690926
Documentation https://docs-ironbank.dso.mil/hardening/choosing-base-image/