Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IronBank BASE_IMAGE with ironbank prefix #102720

Merged
merged 1 commit into from Nov 30, 2023

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Nov 28, 2023

This supports local testing. It should not be included in hardening_manifest.yml, which injects the scope at runtime.

Prompted by https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch/-/merge_requests/140#note_1690926
Documentation https://docs-ironbank.dso.mil/hardening/choosing-base-image/

This supports local testing.  It should not be included in
hardening_manifest.yml, which injects the scope at runtime.
@jbudz jbudz added :Delivery/Build Build or test infrastructure :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts labels Nov 28, 2023
@elasticsearchmachine elasticsearchmachine added Team:Delivery Meta label for Delivery team v8.12.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Nov 28, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@jbudz jbudz added external-contributor Pull request authored by a developer outside the Elasticsearch team v8.12.0 and removed external-contributor Pull request authored by a developer outside the Elasticsearch team v8.12.0 labels Nov 28, 2023
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @jbudz. LGTM.

@mark-vieira mark-vieira added auto-backport-and-merge Automatically create backport pull requests and merge when ready v8.11.2 v7.17.16 labels Nov 30, 2023
@mark-vieira mark-vieira self-assigned this Nov 30, 2023
@mark-vieira mark-vieira merged commit 6787765 into elastic:main Nov 30, 2023
14 checks passed
mark-vieira pushed a commit to mark-vieira/elasticsearch that referenced this pull request Nov 30, 2023
This supports local testing.  It should not be included in
hardening_manifest.yml, which injects the scope at runtime.
mark-vieira pushed a commit to mark-vieira/elasticsearch that referenced this pull request Nov 30, 2023
This supports local testing.  It should not be included in
hardening_manifest.yml, which injects the scope at runtime.
# Conflicts:
#	distribution/docker/src/docker/Dockerfile
elasticsearchmachine pushed a commit that referenced this pull request Nov 30, 2023
This supports local testing.  It should not be included in
hardening_manifest.yml, which injects the scope at runtime.
# Conflicts:
#	distribution/docker/src/docker/Dockerfile

Co-authored-by: Jon <jon@elastic.co>
elasticsearchmachine pushed a commit that referenced this pull request Nov 30, 2023
This supports local testing.  It should not be included in
hardening_manifest.yml, which injects the scope at runtime.

Co-authored-by: Jon <jon@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready :Delivery/Build Build or test infrastructure :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts external-contributor Pull request authored by a developer outside the Elasticsearch team >non-issue Team:Delivery Meta label for Delivery team v7.17.16 v8.11.2 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants