Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add interactive examples section to Sphinx docs #2374

Merged
merged 4 commits into from Nov 16, 2023
Merged

[DOCS] Add interactive examples section to Sphinx docs #2374

merged 4 commits into from Nov 16, 2023

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Nov 14, 2023 •
edited

馃攳 URL preview

Summary

  • Removes interactive examples subsection from index page
  • Gives interactive examples higher prominence in its own section in nav
Screenshot 2023-11-14 at 15 23 38
  • Links to elasticsearch-labs notebooks and mirrors summary of the notebooks in Search folder, which are most relevant to Elasticsearch beginners
  • Links to other notebook categories

pquentin
pquentin approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you.

@pquentin pquentin merged commit f0374b4 into elastic:main Nov 16, 2023
11 checks passed
@github-actions github-actions bot mentioned this pull request Nov 16, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Nov 16, 2023
@leemthompo @github-actions
[DOCS] Add interactive examples section to Sphinx docs (#2374)
531f187 
* [DOCS] Add interactive examples section to Sphinx docs

* Delete comment

* Fix URLs

(cherry picked from commit f0374b4)
pquentin pushed a commit that referenced this pull request Nov 16, 2023
@github-actions @leemthompo
[DOCS] Add interactive examples section to Sphinx docs (#2374) (#2378)
b2e408a 
* [DOCS] Add interactive examples section to Sphinx docs

* Delete comment

* Fix URLs

(cherry picked from commit f0374b4)

Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
Area: Documentation backport 8.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leemthompo @pquentin