Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary code #1971

Merged
merged 1 commit into from Aug 15, 2023
Merged

Remove unnecessary code #1971

merged 1 commit into from Aug 15, 2023

Conversation

wonseop
Copy link
Contributor

@wonseop wonseop commented Aug 15, 2023

Function 'buildPath' is defined without arguments, so I removed an unnecessary argument from the function call.
And I removed a parameter 'param' of function 'genRequiredChecks'.

@wonseop
Remove unnecessary code
db4551e 
Function 'buildPath' is defined without arguments, so I removed an unnecessary argument from the function call.
And I removed a parameter 'param' of function 'genRequiredChecks'.
JoshMock
JoshMock approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. These scripts are mostly unused now, as we've moved code generation into a separate project. Can't hurt to merge the improvement, though. 🖤

@JoshMock
Copy link
Member

jenkins test this

@JoshMock JoshMock merged commit 787b3b0 into elastic:main Aug 15, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshMock JoshMock JoshMock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wonseop @JoshMock