Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include tests in sdist and exclude tests in wheels #122

Merged
merged 3 commits into from Dec 13, 2023
Merged

include tests in sdist and exclude tests in wheels #122

merged 3 commits into from Dec 13, 2023

Conversation

parona-source
Copy link
Contributor

Closes #119

Contents of sdist and wheel before

$ tar -tf elastic-transport-8.4.1.tar.gz 
elastic-transport-8.4.1/
elastic-transport-8.4.1/.github/
elastic-transport-8.4.1/.github/workflows/
elastic-transport-8.4.1/.github/workflows/backport.yml
elastic-transport-8.4.1/.github/workflows/ci.yml
elastic-transport-8.4.1/.gitignore
elastic-transport-8.4.1/.readthedocs.yml
elastic-transport-8.4.1/CHANGELOG.md
elastic-transport-8.4.1/LICENSE
elastic-transport-8.4.1/MANIFEST.in
elastic-transport-8.4.1/PKG-INFO
elastic-transport-8.4.1/README.md
elastic-transport-8.4.1/docs/
elastic-transport-8.4.1/docs/sphinx/
elastic-transport-8.4.1/docs/sphinx/client_utils.rst
elastic-transport-8.4.1/docs/sphinx/conf.py
elastic-transport-8.4.1/docs/sphinx/exceptions.rst
elastic-transport-8.4.1/docs/sphinx/index.rst
elastic-transport-8.4.1/docs/sphinx/installation.rst
elastic-transport-8.4.1/docs/sphinx/logging.rst
elastic-transport-8.4.1/docs/sphinx/node_pool.rst
elastic-transport-8.4.1/docs/sphinx/nodes.rst
elastic-transport-8.4.1/docs/sphinx/serializers.rst
elastic-transport-8.4.1/docs/sphinx/transport.rst
elastic-transport-8.4.1/elastic_transport/
elastic-transport-8.4.1/elastic_transport/__init__.py
elastic-transport-8.4.1/elastic_transport/_async_transport.py
elastic-transport-8.4.1/elastic_transport/_compat.py
elastic-transport-8.4.1/elastic_transport/_exceptions.py
elastic-transport-8.4.1/elastic_transport/_models.py
elastic-transport-8.4.1/elastic_transport/_node/
elastic-transport-8.4.1/elastic_transport/_node/__init__.py
elastic-transport-8.4.1/elastic_transport/_node/_base.py
elastic-transport-8.4.1/elastic_transport/_node/_base_async.py
elastic-transport-8.4.1/elastic_transport/_node/_http_aiohttp.py
elastic-transport-8.4.1/elastic_transport/_node/_http_requests.py
elastic-transport-8.4.1/elastic_transport/_node/_http_urllib3.py
elastic-transport-8.4.1/elastic_transport/_node/_urllib3_chain_certs.py
elastic-transport-8.4.1/elastic_transport/_node_pool.py
elastic-transport-8.4.1/elastic_transport/_response.py
elastic-transport-8.4.1/elastic_transport/_serializer.py
elastic-transport-8.4.1/elastic_transport/_transport.py
elastic-transport-8.4.1/elastic_transport/_utils.py
elastic-transport-8.4.1/elastic_transport/_version.py
elastic-transport-8.4.1/elastic_transport/client_utils.py
elastic-transport-8.4.1/elastic_transport/py.typed
elastic-transport-8.4.1/elastic_transport.egg-info/
elastic-transport-8.4.1/elastic_transport.egg-info/PKG-INFO
elastic-transport-8.4.1/elastic_transport.egg-info/SOURCES.txt
elastic-transport-8.4.1/elastic_transport.egg-info/dependency_links.txt
elastic-transport-8.4.1/elastic_transport.egg-info/requires.txt
elastic-transport-8.4.1/elastic_transport.egg-info/top_level.txt
elastic-transport-8.4.1/noxfile.py
elastic-transport-8.4.1/setup.cfg
elastic-transport-8.4.1/setup.py
elastic-transport-8.4.1/utils/
elastic-transport-8.4.1/utils/build-dists.py
elastic-transport-8.4.1/utils/license-headers.py

$ unzip -l elastic_transport-8.4.1-py3-none-any.whl 
Archive:  elastic_transport-8.4.1-py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
     3737  02-16-2023 09:32   elastic_transport/__init__.py
    19827  09-28-2023 00:45   elastic_transport/_async_transport.py
     3865  02-16-2023 09:32   elastic_transport/_compat.py
     3871  02-16-2023 09:32   elastic_transport/_exceptions.py
    12858  02-16-2023 09:32   elastic_transport/_models.py
    15033  09-28-2023 00:45   elastic_transport/_node_pool.py
     6482  09-28-2023 00:45   elastic_transport/_response.py
     7753  02-16-2023 09:32   elastic_transport/_serializer.py
    22856  09-28-2023 00:45   elastic_transport/_transport.py
     3359  02-16-2023 09:32   elastic_transport/_utils.py
      810  09-28-2023 00:45   elastic_transport/_version.py
     7846  09-28-2023 00:45   elastic_transport/client_utils.py
        0  02-16-2023 09:32   elastic_transport/py.typed
     1148  02-16-2023 09:32   elastic_transport/_node/__init__.py
    11208  02-16-2023 09:32   elastic_transport/_node/_base.py
     1510  02-16-2023 09:32   elastic_transport/_node/_base_async.py
    10373  02-16-2023 09:32   elastic_transport/_node/_http_aiohttp.py
     9979  09-28-2023 00:45   elastic_transport/_node/_http_requests.py
     7996  09-28-2023 00:45   elastic_transport/_node/_http_urllib3.py
     5272  02-16-2023 09:32   elastic_transport/_node/_urllib3_chain_certs.py
    10143  09-28-2023 00:56   elastic_transport-8.4.1.dist-info/LICENSE
     3473  09-28-2023 00:56   elastic_transport-8.4.1.dist-info/METADATA
       92  09-28-2023 00:56   elastic_transport-8.4.1.dist-info/WHEEL
       18  09-28-2023 00:56   elastic_transport-8.4.1.dist-info/top_level.txt
     2245  09-28-2023 00:56   elastic_transport-8.4.1.dist-info/RECORD
---------                     -------
   171754                     25 files

Contents of sdist and wheel after

$ tar -tf elastic-transport-8.4.1.tar.gz
elastic-transport-8.4.1/
elastic-transport-8.4.1/.github/
elastic-transport-8.4.1/.github/workflows/
elastic-transport-8.4.1/.github/workflows/backport.yml
elastic-transport-8.4.1/.github/workflows/ci.yml
elastic-transport-8.4.1/.gitignore
elastic-transport-8.4.1/.readthedocs.yml
elastic-transport-8.4.1/CHANGELOG.md
elastic-transport-8.4.1/LICENSE
elastic-transport-8.4.1/MANIFEST.in
elastic-transport-8.4.1/PKG-INFO
elastic-transport-8.4.1/README.md
elastic-transport-8.4.1/docs/
elastic-transport-8.4.1/docs/sphinx/
elastic-transport-8.4.1/docs/sphinx/client_utils.rst
elastic-transport-8.4.1/docs/sphinx/conf.py
elastic-transport-8.4.1/docs/sphinx/exceptions.rst
elastic-transport-8.4.1/docs/sphinx/index.rst
elastic-transport-8.4.1/docs/sphinx/installation.rst
elastic-transport-8.4.1/docs/sphinx/logging.rst
elastic-transport-8.4.1/docs/sphinx/node_pool.rst
elastic-transport-8.4.1/docs/sphinx/nodes.rst
elastic-transport-8.4.1/docs/sphinx/serializers.rst
elastic-transport-8.4.1/docs/sphinx/transport.rst
elastic-transport-8.4.1/elastic_transport/
elastic-transport-8.4.1/elastic_transport/__init__.py
elastic-transport-8.4.1/elastic_transport/_async_transport.py
elastic-transport-8.4.1/elastic_transport/_compat.py
elastic-transport-8.4.1/elastic_transport/_exceptions.py
elastic-transport-8.4.1/elastic_transport/_models.py
elastic-transport-8.4.1/elastic_transport/_node/
elastic-transport-8.4.1/elastic_transport/_node/__init__.py
elastic-transport-8.4.1/elastic_transport/_node/_base.py
elastic-transport-8.4.1/elastic_transport/_node/_base_async.py
elastic-transport-8.4.1/elastic_transport/_node/_http_aiohttp.py
elastic-transport-8.4.1/elastic_transport/_node/_http_requests.py
elastic-transport-8.4.1/elastic_transport/_node/_http_urllib3.py
elastic-transport-8.4.1/elastic_transport/_node/_urllib3_chain_certs.py
elastic-transport-8.4.1/elastic_transport/_node_pool.py
elastic-transport-8.4.1/elastic_transport/_response.py
elastic-transport-8.4.1/elastic_transport/_serializer.py
elastic-transport-8.4.1/elastic_transport/_transport.py
elastic-transport-8.4.1/elastic_transport/_utils.py
elastic-transport-8.4.1/elastic_transport/_version.py
elastic-transport-8.4.1/elastic_transport/client_utils.py
elastic-transport-8.4.1/elastic_transport/py.typed
elastic-transport-8.4.1/elastic_transport.egg-info/
elastic-transport-8.4.1/elastic_transport.egg-info/PKG-INFO
elastic-transport-8.4.1/elastic_transport.egg-info/SOURCES.txt
elastic-transport-8.4.1/elastic_transport.egg-info/dependency_links.txt
elastic-transport-8.4.1/elastic_transport.egg-info/requires.txt
elastic-transport-8.4.1/elastic_transport.egg-info/top_level.txt
elastic-transport-8.4.1/noxfile.py
elastic-transport-8.4.1/setup.cfg
elastic-transport-8.4.1/setup.py
elastic-transport-8.4.1/tests/
elastic-transport-8.4.1/tests/__init__.py
elastic-transport-8.4.1/tests/async_/
elastic-transport-8.4.1/tests/async_/__init__.py
elastic-transport-8.4.1/tests/async_/test_async_transport.py
elastic-transport-8.4.1/tests/async_/test_httpbin.py
elastic-transport-8.4.1/tests/async_/test_httpserver.py
elastic-transport-8.4.1/tests/conftest.py
elastic-transport-8.4.1/tests/node/
elastic-transport-8.4.1/tests/node/__init__.py
elastic-transport-8.4.1/tests/node/test_base.py
elastic-transport-8.4.1/tests/node/test_http_aiohttp.py
elastic-transport-8.4.1/tests/node/test_http_requests.py
elastic-transport-8.4.1/tests/node/test_http_urllib3.py
elastic-transport-8.4.1/tests/node/test_tls_versions.py
elastic-transport-8.4.1/tests/node/test_urllib3_chain_certs.py
elastic-transport-8.4.1/tests/test_client_utils.py
elastic-transport-8.4.1/tests/test_exceptions.py
elastic-transport-8.4.1/tests/test_httpbin.py
elastic-transport-8.4.1/tests/test_httpserver.py
elastic-transport-8.4.1/tests/test_logging.py
elastic-transport-8.4.1/tests/test_models.py
elastic-transport-8.4.1/tests/test_node_pool.py
elastic-transport-8.4.1/tests/test_package.py
elastic-transport-8.4.1/tests/test_response.py
elastic-transport-8.4.1/tests/test_serializer.py
elastic-transport-8.4.1/tests/test_transport.py
elastic-transport-8.4.1/tests/test_utils.py
elastic-transport-8.4.1/utils/
elastic-transport-8.4.1/utils/build-dists.py
elastic-transport-8.4.1/utils/license-headers.py

$ unzip -l elastic_transport-8.4.1-py3-none-any.whl 
Archive:  elastic_transport-8.4.1-py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
     3737  02-16-2023 09:32   elastic_transport/__init__.py
    19827  09-28-2023 00:45   elastic_transport/_async_transport.py
     3865  02-16-2023 09:32   elastic_transport/_compat.py
     3871  02-16-2023 09:32   elastic_transport/_exceptions.py
    12858  02-16-2023 09:32   elastic_transport/_models.py
    15033  09-28-2023 00:45   elastic_transport/_node_pool.py
     6482  09-28-2023 00:45   elastic_transport/_response.py
     7753  02-16-2023 09:32   elastic_transport/_serializer.py
    22856  09-28-2023 00:45   elastic_transport/_transport.py
     3359  02-16-2023 09:32   elastic_transport/_utils.py
      810  09-28-2023 00:45   elastic_transport/_version.py
     7846  09-28-2023 00:45   elastic_transport/client_utils.py
        0  02-16-2023 09:32   elastic_transport/py.typed
     1148  02-16-2023 09:32   elastic_transport/_node/__init__.py
    11208  02-16-2023 09:32   elastic_transport/_node/_base.py
     1510  02-16-2023 09:32   elastic_transport/_node/_base_async.py
    10373  02-16-2023 09:32   elastic_transport/_node/_http_aiohttp.py
     9979  09-28-2023 00:45   elastic_transport/_node/_http_requests.py
     7996  09-28-2023 00:45   elastic_transport/_node/_http_urllib3.py
     5272  02-16-2023 09:32   elastic_transport/_node/_urllib3_chain_certs.py
    10143  09-28-2023 00:51   elastic_transport-8.4.1.dist-info/LICENSE
     3473  09-28-2023 00:51   elastic_transport-8.4.1.dist-info/METADATA
       92  09-28-2023 00:51   elastic_transport-8.4.1.dist-info/WHEEL
       18  09-28-2023 00:51   elastic_transport-8.4.1.dist-info/top_level.txt
     2245  09-28-2023 00:51   elastic_transport-8.4.1.dist-info/RECORD
---------                     -------
   171754                     25 files

Diff of the RECORD of the wheel installed with and without this change. The difference in hash due to me storing the wheels is slightly different paths.

diff ~/.virtualenvs/t{1,2}/lib/python3.12/site-packages/elastic_transport-8.4.1.dist-info/RECORD 
7c7
< elastic_transport-8.4.1.dist-info/direct_url.json,sha256=_IPOBf0INHOYhqI7AiZYWkxirYq_ualLkaKtgqME10I,297
---
> elastic_transport-8.4.1.dist-info/direct_url.json,sha256=vABtyt9bTB-6nlIH32Q350BShVSmRIEAuRksGELdJXc,302

@cla-checker-service
Copy link

cla-checker-service bot commented Sep 28, 2023 •
edited

💚 CLA has been signed

@parona-source
include tests in sdist and exclude tests in wheels
78b27a7 
Closes elastic#119

Signed-off-by: Alfred Wingate <parona@protonmail.com>
pquentin
pquentin approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@pquentin pquentin merged commit e8bf40d into elastic:main Dec 13, 2023
11 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 13, 2023
@parona-source @github-actions
Include tests in sdist (#122)
2fef384 
Signed-off-by: Alfred Wingate <parona@protonmail.com>
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit e8bf40d)
@github-actions github-actions bot mentioned this pull request Dec 13, 2023
Merged
pquentin pushed a commit that referenced this pull request Dec 13, 2023
@github-actions
[Backport 8.11] Include tests in sdist (#132)
b000391 
* Include tests in sdist (#122)

Signed-off-by: Alfred Wingate <parona@protonmail.com>
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
(cherry picked from commit e8bf40d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
backport 8.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sdist is missing tests
2 participants
@parona-source @pquentin