Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the dependency on urllib3 to >2.0? #102

Closed
johanneskastl opened this issue May 8, 2023 · 6 comments
Closed

Update the dependency on urllib3 to >2.0? #102

johanneskastl opened this issue May 8, 2023 · 6 comments

Comments

@johanneskastl
Copy link

Could the dependency for urllib3 be updated to work with urllib 2.x?
This is one of the modules in my dependency chain, and it seems to be the only one still requiring urllib <2.

Unfortunately, I am not a python guy, so I cannot be of help with the actual implementation...

@aqeelat
Copy link

aqeelat commented Jun 4, 2023

@pquentin @sethmlarson is this something that will be worked on? 👀
I can probably help out here if outside contributors are welcome.

@sethmlarson
Copy link
Contributor

@aqeelat If you could contribute a PR fixing this issue that would be great!

@jgb
Copy link

jgb commented Sep 26, 2023

Any news on this one? There was a patch in #105 but that PR got closed without merging.

@jessicawrr
Copy link

Ask the same. We are blocked by this issue.

@pquentin
Copy link
Member

Working on it in #121 - I need to test it more.

@pquentin
Copy link
Member

8.10.0 supports urllb3 1.26.x and 2.x. This makes me happy as an elastic-transport-python and urllib3 maintainer. :) Closing, thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants