fix: validate tls version in config #287
Merged
+26
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TLSVersion validate method is never called when validating the config causing min supported version to not be enforced bump tls version in tests to 1.2 to avoid failing in fips mode
kruskall
requested review from
AndersonQ and
mauri870
and removed request for
a team
simitt
approved these changes
Mar 5, 2025
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
💛 Build succeeded, but was flaky
Failed CI StepsHistory
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Validate TLS versions when validating the config
Why is it important?
TLSVersion validate method is never called when validating the config causing min supported version to not be enforced
bump tls version in tests to 1.2 to avoid failing in fips mode
Checklist
Author's Checklist
Related issues