Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix winston TAV tests, raise min-supported Winston to 3.3.3 #162

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

trentm
Copy link
Member

@trentm trentm commented Oct 26, 2023

The version specifier was originally 3.3.3 and now I wonder if that
was for a good reason. While attempting to TAV test with node v14
I get timeouts attempting to install winston@3.3.1.

The version specifier was originally 3.3.3 and now I wonder if that
was for a good reason. While attempting to TAV test with node v14
I get timeouts attempting to install winston@3.3.1.
@trentm trentm requested a review from david-luna October 26, 2023 17:15
@trentm trentm self-assigned this Oct 26, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Oct 26, 2023
@trentm trentm merged commit 16a11e8 into main Oct 26, 2023
@trentm trentm deleted the trentm/fix-tav-winston-node14 branch October 26, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants