[GRPC] Fix max span handling in client interceptor #1861
Merged
+16
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
agent-python
community
ckoehn
commented
Jun 26, 2023
basepi
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
This looks perfect! I'll let @beniwohli take a look as well and we'll get this merged.
|
Looks like there's a test failure against 3.11 with the latest grpc. You can ignore the |
|
Thanks for the quick reply. I was able to fix the grpc test. |
|
@elasticmachine, run elasticsearch-ci/docs |
|
Do you already know when this will be included in a release? We are currently affected by it in our production environments and mitigated it to some degree by increasing the max spans per transaction to 1k. But some of our processes occasionally die due to this. |
|
I think we'll probably release early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This change fixes a bug when the maximum amount of spans in a transaction is already reached.
I'm not quite sure about the test though. I was not able to create a functional gRPC test environment on my local machine.
Related issues
Closes #1832