Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure request.headers are always strings (or array of strings) #888

Closed
watson opened this issue Mar 1, 2019 · 1 comment · Fixed by #895
Closed

Ensure request.headers are always strings (or array of strings) #888

watson opened this issue Mar 1, 2019 · 1 comment · Fixed by #895
Assignees
@watson

Comments

@watson
Copy link
Contributor

watson commented Mar 1, 2019

We're considering making this a JSON Schema requirement. So just in case, we need to make sure that headers are always strings or array of strings.

Even if this doesn't make it into the JSON Schema, it's probably a good thing to ensure nonetheless.
@watson watson self-assigned this Mar 1, 2019
watson added a commit to watson/apm-agent-nodejs that referenced this issue Mar 4, 2019
@watson
chore(package): bump elastic-apm-http-client to ^7.1.1
ce6718a 
This version includes a fix that ensures that all reported http headers
are always strings or array of strings.

Fixes elastic#888
@watson watson mentioned this issue Mar 4, 2019
Merged
watson added a commit that referenced this issue Mar 5, 2019
@watson
chore(package): bump elastic-apm-http-client to ^7.1.1 (#895)
f7ef822 
This version includes a fix that ensures that all reported http headers
are always strings or array of strings.

Fixes #888
@ajangus ajangus reopened this Mar 5, 2019
@watson
Copy link
Contributor Author

watson commented Mar 5, 2019

Go home Zube, you're drunk

@watson watson closed this as completed Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@watson watson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(package): bump elastic-apm-http-client to ^7.1.1 watson/apm-agent-nodejs
7 participants
@watson @ajangus @sayden @odacremolbap @kunalvikramsingh @alvarolobato @BernardIsibor