Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@aws-sdk/client-sns): do not crash if there is no current transaction #4168

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

trentm
Copy link
Member

@trentm trentm commented Jul 30, 2024

Before this change, instrumentation of @aws-sdk/client-sns would crash
if there wasn't a current transaction.

Fixes: #4138

…tion

Before this change, instrumentation of `@aws-sdk/client-sns` would *crash*
if there wasn't a current transaction.

Fixes: #4138
@trentm trentm requested a review from david-luna July 30, 2024 18:30
@trentm trentm self-assigned this Jul 30, 2024
@trentm trentm merged commit 9c81da0 into main Jul 30, 2024
18 checks passed
@trentm trentm deleted the trentm/fix-client-sns-no-tx branch July 30, 2024 21:18
trentm added a commit that referenced this pull request Aug 1, 2024
…tion (#4168)

Before this change, instrumentation of `@aws-sdk/client-sns` would *crash*
if there wasn't a current transaction.

Fixes: #4138
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
…tion (elastic#4168)

Before this change, instrumentation of `@aws-sdk/client-sns` would *crash*
if there wasn't a current transaction.

Fixes: elastic#4138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of null (reading 'propagateTraceContextHeaders')
2 participants