Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale files in published packages? #298

Closed
NathanHowell opened this issue May 12, 2020 · 2 comments
Closed

Stale files in published packages? #298

NathanHowell opened this issue May 12, 2020 · 2 comments
Labels
confirmed Issue has been confirmed

Comments

@NathanHowell
Copy link

It appears that some old files (from 5.x?) are being published in 6.1.3, see https://cdn.jsdelivr.net/npm/sitemap@6.1.3/dist/lib/sitemap.js

I don't see this file created if I build locally, and it references dependencies that are no longer used such as xmlbuilder:

"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
/* eslint-disable camelcase, semi */
/*!
 * Sitemap
 * Copyright(c) 2011 Eugene Kalinin
 * MIT Licensed
 */
const xmlbuilder_1 = require("xmlbuilder");
const sitemap_item_1 = require("./sitemap-item");
const types_1 = require("./types");
const zlib_1 = require("zlib");
const url_1 = require("url");
const fs_1 = require("fs");
const utils_1 = require("./utils");
const sitemap_stream_1 = require("./sitemap-stream");
function boolToYESNO(bool) {
    if (bool === undefined) {
        return bool;
    }
    if (typeof bool === 'boolean') {
        return bool ? types_1.EnumYesNo.yes : types_1.EnumYesNo.no;
    }
    return bool;
}
@derduher
Copy link
Collaborator

weird. I'll take a look after I get done with my day job.

@NathanHowell
Copy link
Author

👍 I was upgrading some code and ran into this. If I remove the references to the legacy modules everything seems to work fine, possibly just need to add a git clean -xfd type of action to the publishing script?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Issue has been confirmed
Projects
None yet
Development

No branches or pull requests

2 participants