Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin does not resolve "extends" field for tsconfig #371

Closed
vmizg opened this issue Sep 28, 2023 · 4 comments
Closed

Plugin does not resolve "extends" field for tsconfig #371

vmizg opened this issue Sep 28, 2023 · 4 comments
Labels

Comments

@vmizg
Copy link

vmizg commented Sep 28, 2023

ESBuild themselves support the "extends" field in tsconfig. This still prevents my build when using the new version due to missing TS configuration options from the base file. My base file has "experimentalDecorators": true, which, when not read, results in the issue reported here: #365.

For example:

tsconfig.base.json

{
  "compilerOptions": {
    "experimentalDecorators": true
  }
}

tsconfig.json

{
  "extends": "./tsconfig.base.json"
}

The problem here is that the referenced fix uses the tsconfigRaw property which expects a fully resolved config.

Could we not use the tsconfig property instead of tsconfigRaw and leave the reading and resolution of the file contents to esbuild, as it supports that out of the box?

@vmizg
Copy link
Author

vmizg commented Sep 28, 2023

I'll be using get-tsconfig for the time being to overcome this by manually passing tsconfigRaw to the options object. Hope this helps someone who stumbles upon this.

@sxzz sxzz closed this as completed in e95cc41 Sep 28, 2023
@sxzz
Copy link
Collaborator

sxzz commented Sep 28, 2023

Fixed!

sxzz added a commit that referenced this issue Sep 28, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 6.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vmizg
Copy link
Author

vmizg commented Oct 4, 2023

That was quick. Thanks, @sxzz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants