fix: replace NODE_ENV for umd/iife (fix #274) #337
Merged
+163
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fi3ework
commented
Apr 25, 2020
fi3ework
commented
- test passed
- snapshot added
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/egoist/bili/a8umykfjx |
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 75.23% 76.16% +0.93%
==========================================
Files 11 11
Lines 424 428 +4
Branches 160 161 +1
==========================================
+ Hits 319 326 +7
+ Misses 100 97 -3
Partials 5 5
Continue to review full report at Codecov.
|
egoist
reviewed
Apr 25, 2020
egoist
approved these changes
Apr 26, 2020
|
🎉 This PR is included in version 4.9.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| @@ -282,6 +282,14 @@ export class Bundler { | |||
|
|
|||
| const env = Object.assign({}, config.env) | |||
|
|
|||
| // drop precess.env.NODE_ENV from umd/iife | |||
There was a problem hiding this comment.
typo: precess -> process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.