Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default boot set #568

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

NullVoxPopuli
Copy link
Contributor

In the wake of #564 and the complexity introduced by: #566:

This PR inverts the default (intended bug fix, due to the bugs introduced by #553)

For folks that need the early boot set, you'll need to opt in.

The earlyBootSet is still a function, and still receives the default recommended values:

autoImport: {
  earlyBootSet(defaults) {
    return [...defaults];
  }
}

cc @simonihmig @vitch

Verified

This commit was signed with the committer’s verified signature. The key has expired.
LiviaMedeiros Livia Medeiros
@NullVoxPopuli
Copy link
Contributor Author

@ef4 the tests that work with the earlyBootSet set the option manually. All existing tests are passing -- lemme know if you think more is needed

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review February 22, 2023 15:37
@ef4 ef4 merged commit b9383a5 into embroider-build:main Feb 22, 2023
@NullVoxPopuli NullVoxPopuli deleted the change-default-boot-set branch February 22, 2023 16:15
@jelhan
Copy link
Contributor

jelhan commented Feb 22, 2023

Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants