Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v1 addons that could be consumed by v2 addons in module-scope to … #553

Merged
merged 17 commits into from
Jan 24, 2023

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Dec 8, 2022

…a list that loads them earlier in AMD

Partially resolves: #504

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review December 15, 2022 23:48
@NullVoxPopuli
Copy link
Contributor Author

@ef4 I'm unsure of the value of the added test -- it seems this bug is really really hard to reproduce.

however I was able to yarn link ember-auto-import to my problematic apps, and confirm that this addresses the issue those apps were facing.

@ef4
Copy link
Collaborator

ef4 commented Jan 11, 2023

Next step here is to remove things from the early boot set when their corresponding real package isn't in the app's package.json dependencies / devDependencies. This comes up in the test suite because our oldest supported ember doesn't support @glimmer/tracking.

@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Jan 11, 2023

The fun deepens.
on that ember-source 3.4 + fastboot scenario, we get (after removing @glimmer/tracking from the early boot set because it is not present in the package.json):

loader.js:247 Uncaught Error: Could not find module `@ember/service/index` imported from `__v1-addons__early-boot-set__`

and yet, here it is 🙃 (actually in vendor.js)
image

@NullVoxPopuli
Copy link
Contributor Author

I disabled the feature entirely for old ember.

@NullVoxPopuli
Copy link
Contributor Author

Green, sans ie11 timeout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 addons don't always get ideal execution order
2 participants