Add support for consumers using Node ES Module support (e.g. type=module in package.json)
#544
+49
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rwjblue |
hjdivad
force-pushed
the
hjblue/node-esm
branch
from
76655e2 to
0ca67ee
Compare
|
I'd request a review but I guess I don't have commit to this repo. Anyhoo LMK if you're generally +1, want to see any changes &c. |
|
Looks good, but can we land the ember-cli PR so we don't need to install that branch? |
Adds support for Ember addons that opt-in to node's ES module syntax via type=module. When writing to a directory whose package.json is controlled by a third party, maximum compatibility is achieved by writing either `.cjs` or `.mjs` files as appropriate, and not `.js` files. If neither package is concerned with backwards compatibility, writing ES modules into a `.js` file can be fine, but writing commonjs modules into a `.js` file in a directory whose package.json is controlled by a third party (e.g. another package) is not generally going to be forwards-compatible Co-authored-by: Robert Jackson <rjackson@linkedin.com>
rwjblue
force-pushed
the
hjblue/node-esm
branch
from
0ca67ee to
54cd274
Compare
|
Landed ember-cli/ember-cli#10053, and updated this PR to just use |
rwjblue
added
enhancement
rwjblue
changed the title
type=module in package.json)
|
@ef4 ember-cli PR landed and this one updated; this PR should be good to merge. LMK if you'd like to see any other changes. |
|
@ef4 - I think everything's been resolved here (the ember-cli change has landed, and is included in |
|
This is released in 2.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Ember addons that opt-in to node's ES module syntax via
type=module.
When writing to a directory whose package.json is controlled by a third
party, maximum compatibility is achieved by writing either
.cjsor.mjsfiles as appropriate, and not
.jsfiles.If neither package is concerned with backwards compatibility, writing ES
modules into a
.jsfile can be fine, but writing commonjs modules intoa
.jsfile in a directory whose package.json is controlled by a thirdparty (e.g. another package) is not generally going to be
forwards-compatible.
See also ember-cli/ember-cli#10053 (comment)
Co-authored-by: Robert Jackson rjackson@linkedin.com