Deleting Values #1984
Merged
Deleting Values #1984
+67
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdirix
requested changes
Jul 24, 2022
packages/core/src/util/cell.ts
Outdated
|
|
||
| function getEmptyLabel(props: OwnPropsOfEnumCell, state: JsonFormsState) { | ||
| const t = getTranslator()(state); | ||
| return t(getI18nKey(props.schema, props.uischema, props.path, 'empty'), 'empty'); |
packages/core/src/util/renderer.ts
Outdated
| @@ -260,6 +260,7 @@ export interface OwnPropsOfLabel extends OwnPropsOfRenderer { | |||
|
|
|||
| export interface OwnPropsOfEnum { | |||
| options?: EnumOption[]; | |||
| emptyLabel?: string; | |||
There was a problem hiding this comment.
Hmm I don't think we should handle this via the props. For me this seems like more a decision on the renderer side whether they want to offer a None option.
| @@ -49,11 +50,11 @@ export const MuiSelect = React.memo((props: EnumCellProps & WithClassname) => { | |||
| disabled={!enabled} | |||
| autoFocus={appliedUiSchemaOptions.focus} | |||
| value={data !== undefined ? data : ''} | |||
| onChange={ev => handleChange(path, ev.target.value)} | |||
| onChange={ev =>handleChange(path, ev.target.value === '' ? undefined : ev.target.value)} | |||
There was a problem hiding this comment.
This will delete values which are empty on purpose. We really need to check whether this was our None entry.
There was a problem hiding this comment.
On further inspection it seems it's not straightforward to get this information out of Material UI's Select.
empty input now delete attributes closes eclipsesource#1983 Signed-off-by: Lukas Boll lukas-bool@web.de
- determine label in renderers - adapt angular material controls for consistency - adapt vue vanilla controls for consistency
sdirix
approved these changes
Jul 25, 2022
This was referenced Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add empty option for enum
empty input now deletes attributes.
closes #1983