Add ALPN support #790
Merged
Add ALPN support #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank, but I've an issue regarding Eclipse requirement with this PR: since some change are authored by @michaelboulton which don't seems to have signed the ECA (https://accounts.eclipse.org/user/eca) I'm not sure I'm allowed to merge it. @michaelboulton could you complet the ECA signing ? https://accounts.eclipse.org/user/eca |
|
@PierreF Hm, well, I signed-off on this (with a |
|
Rebased post #791. |
Co-authored-by: Michael Boulton <michaelboulton@gmail.com> Signed-off-by: Aarni Koskela <akx@iki.fi>
|
Since the change is rather small, I think it's okay to merge it even if first author didn't fully complete the ECA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #648 (reworks it to adhere to the new test system).
Also simplifies the SSL/server test fixtures a bit for great happiness.