Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MaximumQoS property from CONNECT packet #161 #243

Conversation

tomatod
Copy link
Contributor

@tomatod tomatod commented Feb 18, 2024

Do not create a Pull Request without creating an issue first
#161 was created related to this request.

The design of your solution to the problem should be discussed and agreed in an issue before submitting the PR
According to MQTTv5 spec, Maximum QoS property should not be included in CONNECT packet. Actually, when I tried to send CONNECT packet included that property to Mosquitto MQTT server, the connection was refused by Mosquitto. So, I think we should remove Maximum QoS property from CONNECT packet in this library.

note: This request is same with #240, but I remaked the request after some confirmations, because there was a problem with test on my envrionment (#242). As a result, the problem wasn't probably related to this change.

ECA - Eclipse Contributer Agreement
had already done

Testing

  • make test was passed. I sometimes catched an issue with An autopaho test TestQueuedMessage may be not passed. #242, but tests were passed temporarily with making the timeout of autopaho's cm longer.
  • I confirmed almost all parts related to this change with grep ''QOS" or "QoS" (including "MaximumQoS" and "MaximumQOS") just in case.

Closing issues
closes #161

@MattBrittan
Copy link
Contributor

Thanks very much for submitting this.

@MattBrittan MattBrittan merged commit 79a760b into eclipse:master Feb 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConnectProperties in cp_connect.go has a MaximumQOS field that is not part of the MQTT 5 specification
2 participants