TCK: fix several incorrectly used annotations and associated tests #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Edgar <michael@xlate.io>
|
@Emily-Jiang , let me know if you see anything changing here that would be an issue for a micro-release, v3.1.1 |
Azquelt
reviewed
Apr 19, 2023
There was a problem hiding this comment.
Thanks for doing this and picking out the invalid parts of the TCK app.
I have a few concerns where it looks like we could be adding a test rather than fixing one which we wouldn't want to do in a micro release and a few where I'm unsure if the change is correct.
tck/src/main/java/org/eclipse/microprofile/openapi/apps/airlines/resources/ReviewResource.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/eclipse/microprofile/openapi/apps/airlines/resources/UserResource.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/eclipse/microprofile/openapi/apps/petstore/resource/PetResource.java
Show resolved
Hide resolved
tck/src/main/java/org/eclipse/microprofile/openapi/apps/petstore/resource/PetResource.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/eclipse/microprofile/openapi/apps/petstore/resource/PetResource.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/eclipse/microprofile/openapi/apps/petstore/resource/PetResource.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Rouse <anrouse@uk.ibm.com>
Signed-off-by: Michael Edgar <michael@xlate.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #322
There are several remaining issues reported by the OpenAPI validator [1] including:
/user/specialmissing schemas, this is intentional to test hidden schema functionality/userPOST request body encoding includes an extensionx-encodingflagged invalid by the parser. This appears to be a bug [2]I verified that the smallrye-open-api implementation's
mainbranch passes with these modifications.[1] https://validator.swagger.io/
[2] OAI/OpenAPI-Specification#3251